Skip to content

Add Python lint workflow using ruff#23

Merged
vannu07 merged 4 commits intovannu07:mainfrom
chiragveerwani:add-python-lint-workflow
Oct 14, 2025
Merged

Add Python lint workflow using ruff#23
vannu07 merged 4 commits intovannu07:mainfrom
chiragveerwani:add-python-lint-workflow

Conversation

@chiragveerwani
Copy link
Copy Markdown
Contributor

@chiragveerwani chiragveerwani commented Oct 13, 2025

📝 Description

This pull request adds a GitHub Actions workflow to automatically lint Python code on every push and pull request using ruff.
The workflow checks all Python files in the backend/ folder as well as main.py and run.py at the root.
This improves code quality and style consistency across all contributors.

Fixes #12


✅ Type of Change

  • Bug fix
  • New feature
  • Enhancement
  • Documentation update
  • Security improvement

🔍 Checklist

  • My code follows the project’s style guidelines.
  • I’ve run linting and tests locally.
  • I’ve added necessary documentation.
  • I’ve tested the changes thoroughly.

💬 Additional Context

Adds .github/workflows/python-lint.yml and prepares the project for lint status badge in README after first workflow run.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message that will be displayed on users' first pull request

@chiragveerwani
Copy link
Copy Markdown
Contributor Author

Hi @vannu07,
This PR adds a new Python lint workflow using ruff. The workflow is awaiting approval to run. could you please review and approve the workflow? Thank you!

@vannu07 vannu07 marked this pull request as ready for review October 13, 2025 13:51
@vannu07
Copy link
Copy Markdown
Owner

vannu07 commented Oct 13, 2025

Thanks for setting up the ruff linting workflow. That's a great addition.

I'm seeing a display issue where the .github/workflows/python-lint.yml file seems to be showing as "Empty file." in the commit view. Since the checks passed, I know it has content, but could you confirm the file contents look correct?

@chiragveerwani
Copy link
Copy Markdown
Contributor Author

I updated the file, Can you please check?

@vannu07
Copy link
Copy Markdown
Owner

vannu07 commented Oct 13, 2025

Hi @chiragveerwani 👋

Thanks again for adding the Ruff lint workflow — great initiative to improve our code quality!

I noticed the “Python Lint / lint (pull_request)” check is currently failing after about 8 seconds. That usually indicates Ruff detected some linting or formatting issues in the codebase.

Could you please run the following command locally to identify and fix the issues?

pip install ruff
ruff check backend/ main.py run.py --fix

This will automatically correct minor issues (like formatting or unused imports).

After applying the fixes, please push the changes again — the workflow will re-run automatically.

Everything else in the workflow setup looks perfect . Once the lint check passes, I’ll go ahead and approve and merge this PR.

Thanks for your effort in keeping our repository clean and well-structured!

@chiragveerwani
Copy link
Copy Markdown
Contributor Author

Hi @vannu07, I have fixed the issues, Can you please check it now?

@vannu07 vannu07 merged commit 02ab8c2 into vannu07:main Oct 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI/CD] Add Python Linting Workflow using GitHub Actions

2 participants